Skip to content

refactor: remove SubscriptionSection component and related API for cl… #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artem1211 merged 2 commits into from
Oct 29, 2025
Merged

refactor: remove SubscriptionSection component and related API for cl… #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b38592c
refactor: remove SubscriptionSection component and related API for cl…
Artem1211 Oct 29, 2025
e9a3057
fix: update BorrowIncreaseModal to use correct currency rates for min…
Artem1211 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...pp/src/features/liquidity-flow/components/borrow-increase-modal/borrow-increase-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,11 @@ export function BorrowIncreaseModal({
const minDebtUsd = useMinDebtUsd();

const currencyRates = useContextSelector(CurrencyRatesContext, (state) => state.currencyRates);
const currencyRate = Number(currencyRates?.[tokenName.toUpperCase() || '']);
const coreCurrencyRate = Number(currencyRates?.[coreDebtTokenName.toUpperCase() || '']);
const extraCurrencyRate = Number(currencyRates?.[extraDebtTokenName?.toUpperCase() || '']);
Comment thread
Artem1211 marked this conversation as resolved.

const minimumRequired = currencyRate * minDebtUsd;
const extraMinimumRequired = currencyRate * minDebtUsd;
const minimumRequired = coreCurrencyRate * minDebtUsd;
const extraMinimumRequired = extraCurrencyRate * minDebtUsd;

const isDebtBiggerThanMinimum = Number(value) >= minimumRequired;

Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/features/liquidity-flow/utils/get-max-debt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ export const getMaxDebt = (
availableToBorrow: number,
defaultBorrowCapacity: number,
priceInUsd: number,
) => Math.min(availableToBorrow, Number((defaultBorrowCapacity / priceInUsd).toFixed(3)));
) => Math.min(availableToBorrow, Number((defaultBorrowCapacity * priceInUsd).toFixed(3)));
Comment thread
Artem1211 marked this conversation as resolved.
15 changes: 0 additions & 15 deletions packages/landing/src/widgets/landing/components/subscription-section/api.ts
View file
Open in desktop

This file was deleted.

69 changes: 0 additions & 69 deletions ...ages/landing/src/widgets/landing/components/subscription-section/subscription-section.tsx
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/landing/src/widgets/landing/landing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import React from 'react';
import Image from 'next/image';
import { SubscriptionSection } from '@/widgets/landing/components/subscription-section/subscription-section';
import Typography from '@marginly/ui/components/typography';
import Button from '@marginly/ui/components/button';
import NextLink from 'next/link';
Expand Down Expand Up @@ -203,7 +202,6 @@ export function Landing({ posts }: Props) {
}}
/>
</LaunchBg>
<SubscriptionSection />
</Launch>
<Container>
<QuestionSection subscriptionAnchor={SUBSCRIPTION_ANCHOR} />
Expand Down
Loading