Skip to content

Pint auto coordinate rescaling#124

Open
JoelLucaAdams wants to merge 3 commits into
mainfrom
pint-auto-coordinate-rescaling
Open

Pint auto coordinate rescaling#124
JoelLucaAdams wants to merge 3 commits into
mainfrom
pint-auto-coordinate-rescaling

Conversation

@JoelLucaAdams

Copy link
Copy Markdown
Collaborator

Adds support to use pint to automatically rescale coordinates utilising the units only. This breaks the existing rescale_coords function as it changes the order of parameters moving the multiplier down to the bottom and making it optional. If the multiplier is not specified then pint is used to automatically rescale.

Closes #72

@LiamPattinson LiamPattinson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! You'll just need to add a big warning to your next release notes saying there's a breaking change. It might be worth compiling those in a BREAKING_CHANGES.md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use pint to automate unit scaling

2 participants