running with docker#205
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 290a816d87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| Xvfb "$DISPLAY" -screen 0 "$XVFB_WHD" -ac +extension GLX +render -noreset & | ||
| fluxbox >/tmp/fluxbox.log 2>&1 & | ||
| x11vnc -display "$DISPLAY" -forever -shared -rfbport 5900 -nopw >/tmp/x11vnc.log 2>&1 & |
There was a problem hiding this comment.
The startup script launches x11vnc with -nopw, and this compose setup publishes the desktop ports, so any user/process that can reach those ports can control the GUI session without authentication. This is a real remote-control risk on shared machines or non-local deployments; add VNC/noVNC authentication (or restrict exposure to localhost-only) before publishing these endpoints.
Useful? React with 👍 / 👎.
1 participant
No description provided.