ci: consolidate GitHub actions and run only on pull request, no duplicate runs on each push - #48
Open
joescottdave wants to merge 3 commits into
Open
ci: consolidate GitHub actions and run only on pull request, no duplicate runs on each push#48joescottdave wants to merge 3 commits into
joescottdave wants to merge 3 commits into
Conversation
…cate runs on each push
RuboCop was attempting to load the rubocop-rake plugin on CI and crashing since it wasn't installed. Add both suggested plugins as dev dependencies and register them in .rubocop.yml, then fix the Minitest/EmptyLineBeforeAssertionMethods offenses they surfaced.
ajtucker
approved these changes
Aug 19, 2026
ajtucker
left a comment
ajtucker
left a comment
There was a problem hiding this comment.
Looks good, thanks @joescottdave. We could consolidate further and have the type-checker run directly after the unit tests (and rbs collection install), so as to avoid duplicate checkout, ruby setup and bundle install?
But this is fine for now. I'll raise a separate ticket, as this needs doing across multiple repos.
Contributor
Author
|
I think I'm happy for them to remain separate jobs so that they can run in parallel and we can see which thing failed at a glance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #46