separate encoders for cs and lon data#16
Open
kohpangwei wants to merge 1 commit into
Open
Conversation
epierson9
reviewed
May 13, 2018
| # Longitudinal encoder layers. | ||
| for encoder_layer_idx, encoder_layer_size in enumerate(self.encoder_layer_sizes): | ||
| if encoder_layer_idx == 0: | ||
| input_dim = 2 * (len(self.feature_names) + self.include_age_in_encoder_input) |
Owner
There was a problem hiding this comment.
will this work? doesn't this include age twice? but then it seems like you actually only include it once?
Collaborator
Author
There was a problem hiding this comment.
hm I think I pass in ages twice? one of it is in the direct encode call, which is pretty janky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@epierson9 PTAL