Add --test mode to start.sh for CI validation - #82
Conversation
Run the full startup sequence (ibek asset generation, msi db expansion) but skip hardware connections (ibek ioc do-wait) and the IOC binary launch. Pass "$@" through when delegating to a config-override start.sh so the flag reaches IOC-specific scripts (e.g. ioc-adaravis). Usage: /epics/ioc/start.sh --test
|
Warning Review limit reached
Next review available in: 37 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe IOC startup script adds a ChangesIOC startup behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
template/ioc/start.sh (1)
49-49: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winQuote executable paths before execution.
Unquoted
CONFIG_DIR,IOC, andRUNTIME_DIRcan split paths or expand glob patterns. Quote each complete path.
template/ioc/start.sh#L49-L49: change the script path to"${CONFIG_DIR}/start.sh".template/ioc/start.sh#L105-L105: change the IOC binary path to"${IOC}/bin/linux-x86_64/ioc"and the startup file path to"${RUNTIME_DIR}/st.cmd".Proposed fix
- exec bash ${CONFIG_DIR}/start.sh "$@" + exec bash "${CONFIG_DIR}/start.sh" "$@" ... - ${IOC}/bin/linux-x86_64/ioc ${RUNTIME_DIR}/st.cmd + "${IOC}/bin/linux-x86_64/ioc" "${RUNTIME_DIR}/st.cmd"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@template/ioc/start.sh` at line 49, Quote all executable and startup file paths in template/ioc/start.sh: at lines 49-49, quote the CONFIG_DIR-based start script path; at lines 105-105, quote both the IOC binary path and the RUNTIME_DIR-based st.cmd path to prevent word splitting and glob expansion.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@template/ioc/start.sh`:
- Line 49: Quote all executable and startup file paths in template/ioc/start.sh:
at lines 49-49, quote the CONFIG_DIR-based start script path; at lines 105-105,
quote both the IOC binary path and the RUNTIME_DIR-based st.cmd path to prevent
word splitting and glob expansion.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: be45d1e9-484e-4d37-ac0b-53ef622526ce
📒 Files selected for processing (1)
template/ioc/start.sh
The quotes keep the executable and startup file path as a single argument regardless of whitespace in the variable values
Run the full startup sequence (ibek asset generation, msi db expansion) but skip hardware connections (ibek ioc do-wait) and the IOC binary launch. Pass "$@" through when delegating to a config-override start.sh so the flag reaches IOC-specific scripts (e.g. ioc-adaravis).
Usage: /epics/ioc/start.sh --test
Summary by CodeRabbit