Skip to content

Add --test mode to start.sh for CI validation - #82

Open
ggayDiamond wants to merge 2 commits into
mainfrom
ci-validation-mode
Open

Add --test mode to start.sh for CI validation#82
ggayDiamond wants to merge 2 commits into
mainfrom
ci-validation-mode

Conversation

@ggayDiamond

@ggayDiamond ggayDiamond commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Run the full startup sequence (ibek asset generation, msi db expansion) but skip hardware connections (ibek ioc do-wait) and the IOC binary launch. Pass "$@" through when delegating to a config-override start.sh so the flag reaches IOC-specific scripts (e.g. ioc-adaravis).

Usage: /epics/ioc/start.sh --test

Summary by CodeRabbit

  • New Features
    • Added a test mode that generates runtime assets without waiting for hardware or launching the IOC.
    • Startup overrides now receive the original command-line arguments.
  • Bug Fixes
    • Kept normal startup behavior unchanged outside of test mode.

Run the full startup sequence (ibek asset generation, msi db expansion)
but skip hardware connections (ibek ioc do-wait) and the IOC binary
launch. Pass "$@" through when delegating to a config-override start.sh
so the flag reaches IOC-specific scripts (e.g. ioc-adaravis).

Usage: /epics/ioc/start.sh --test
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@ggayDiamond, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4301f0ef-0faa-4830-b757-ffaf8500c99a

📥 Commits

Reviewing files that changed from the base of the PR and between b85c649 and af35b20.

📒 Files selected for processing (1)
  • template/ioc/start.sh
📝 Walkthrough

Walkthrough

The IOC startup script adds a --test mode. This mode generates runtime assets without hardware waits or IOC launch. Configuration startup overrides receive the original arguments. Normal startup remains unchanged.

Changes

IOC startup behavior

Layer / File(s) Summary
Test-mode startup handling
template/ioc/start.sh
The script detects --test, passes the original arguments to configuration startup overrides, skips hardware waits, and reports successful runtime generation without launching the IOC.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: gilesknap

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a --test mode to start.sh for CI validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-validation-mode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ggayDiamond
ggayDiamond marked this pull request as ready for review August 5, 2026 15:02

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
template/ioc/start.sh (1)

49-49: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Quote executable paths before execution.

Unquoted CONFIG_DIR, IOC, and RUNTIME_DIR can split paths or expand glob patterns. Quote each complete path.

  • template/ioc/start.sh#L49-L49: change the script path to "${CONFIG_DIR}/start.sh".
  • template/ioc/start.sh#L105-L105: change the IOC binary path to "${IOC}/bin/linux-x86_64/ioc" and the startup file path to "${RUNTIME_DIR}/st.cmd".
Proposed fix
-    exec bash ${CONFIG_DIR}/start.sh "$@"
+    exec bash "${CONFIG_DIR}/start.sh" "$@"
...
-    ${IOC}/bin/linux-x86_64/ioc ${RUNTIME_DIR}/st.cmd
+    "${IOC}/bin/linux-x86_64/ioc" "${RUNTIME_DIR}/st.cmd"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@template/ioc/start.sh` at line 49, Quote all executable and startup file
paths in template/ioc/start.sh: at lines 49-49, quote the CONFIG_DIR-based start
script path; at lines 105-105, quote both the IOC binary path and the
RUNTIME_DIR-based st.cmd path to prevent word splitting and glob expansion.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@template/ioc/start.sh`:
- Line 49: Quote all executable and startup file paths in template/ioc/start.sh:
at lines 49-49, quote the CONFIG_DIR-based start script path; at lines 105-105,
quote both the IOC binary path and the RUNTIME_DIR-based st.cmd path to prevent
word splitting and glob expansion.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: be45d1e9-484e-4d37-ac0b-53ef622526ce

📥 Commits

Reviewing files that changed from the base of the PR and between 72ae4a9 and b85c649.

📒 Files selected for processing (1)
  • template/ioc/start.sh

The quotes keep the executable and startup file path as a single
argument regardless of whitespace in the variable values
@ggayDiamond
ggayDiamond requested a review from gilesknap August 5, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant