Fixes for issues triggered by Windows CI - #227
Open
anjohnson wants to merge 3 commits into
Open
Conversation
Two timing-sensitive failures seen on the windows-x64-mingw CI runner (statically linked, single CPU): testChannelAccess test 148 "an array setLength failed (4)". Move stopRequest() before the payload block in several ServerChannel...RequesterImpl::send() methods. testCaProvider crash on exit: Release the global testChannelProvider deterministically on the main thread before returning from main(). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Now the inverse of start() by unregistering the ca provider. stop() is safe to call more than once or without a matching start(). Note this does not force teardown of a CAChannelProvider instance already handed out: that instance (and its worker threads and CA context) stays alive until its owners release their references. Callers wanting a controlled teardown must drop those references and call stop(), rather than relying on a static destructor at process exit -- which is unsafe on Windows, where the EPICS exit handlers are not run when main() returns. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
✅ Build pvAccessCPP 1.0.162 completed (commit 66ca4a4a3e by @anjohnson) |
Member
Author
|
Added another fix for requester callback diagnostics in testChannelAccess: Collect |
|
✅ Build pvAccessCPP 1.0.164 completed (commit f05ba1f2eb by @anjohnson) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
stopRequest()calls in responseHandlers.cppRequesterImpl::send()methods to before the payload gets serialized. See Matej's similar move and comments in the ChannelGet code when he was working on performance. The testChannelAccess test 148 fails with "other request pending" because of this ordering.The factory stop method prevents crashes in the testCaProvider code during process shutdown.