Potential fix for testChannelAccess tests - #224
Merged
Conversation
Up to standards ✅🟢 Issues
|
|
❌ Build pvAccessCPP 1.0.152 failed (commit 345da0d5d5 by @anjohnson) |
|
❌ Build pvAccessCPP 1.0.152 failed (commit 345da0d5d5 by @anjohnson) |
Bug analysis and fix developed by Claude Opus 4.6: Root cause: A race condition in SyncChannelArrayRequesterImpl in syncTestRequesters.h:1382-1433. The waitUntilGetArrayDone (and Put/SetLength variants) reset their status flag to false after the async request was already sent. If the callback fires before the reset (common on a single-CPU system where the test thread gets preempted), the callback's true status is overwritten, and the test reports a spurious failure despite the operation succeeding. Fix: Moved the status reset from the waitUntil*Done methods into the sync* methods, before the async call is sent, to match the pattern used by the other requester classes in the file (SyncChannelGetRequesterImpl, SyncChannelPutRequesterImpl, etc.).
anjohnson
force-pushed
the
fix-testChannelAccess
branch
from
July 6, 2026 12:33
c679265 to
8302464
Compare
|
✅ Build pvAccessCPP 1.0.158 completed (commit 9b8c280a70 by @anjohnson) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug analysis and fix developed by Claude Opus 4.6:
Root cause: A race condition in SyncChannelArrayRequesterImpl in
syncTestRequesters.h:1382-1433. The waitUntilGetArrayDone (and
Put/SetLength variants) reset their status flag to false after the
async request was already sent. If the callback fires before the
reset (common on a single-CPU system where the test thread gets
preempted), the callback's true status is overwritten, and the test
reports a spurious failure despite the operation succeeding.
Fix: Moved the status reset from the waitUntilDone methods into the
sync methods, before the async call is sent, to match the pattern
used by the other requester classes in the file
(SyncChannelGetRequesterImpl, SyncChannelPutRequesterImpl, etc.).