add default message for pvget - #195
Conversation
|
✅ Build pvAccessCPP 1.0.100 completed (commit 6a0c4f85bf by @rerpha) |
|
✅ Build pvAccessCPP 1.0.101 completed (commit 84f932cae9 by @rerpha) |
|
✅ Build pvAccessCPP 1.0.102 completed (commit a9eb144842 by @rerpha) |
That default case should be impossible so long as the
I guess you are referring to It think it is a bit of a judgement call whether PVs is an error with Is it worth changing behavior at this point? |
by other tools yes caget, but also pvput, pvinfo, pvmonitor all seem to give the "No pv name(s) specified. ('pvXXXX -h' for help.)" message - just thinking for consistency among the pv* utils it might be nice. |
|
✅ Build pvAccessCPP 1.0.111 completed (commit ef35bf3698 by @rerpha) |
|
❌ Build pvAccessCPP 1.0.116 failed (commit 9a1e4a8a81 by @rerpha) |
anjohnson
left a comment
There was a problem hiding this comment.
Thank-you, this looks fine now.
Just a note for any future Pull Requests you make that have more complex changes and more than one commit: Please don't use git pull after committing changes, since that adds a merge commit to your PR branch. Our preferred method of moving your changes up to the latest commit on the 7.0 branch is to do a git pull --rebase. In this case though we will squash your changes into a single commit when we merge it so you don't need to do anything more here.
|
❌ Build pvAccessCPP 1.0.117 failed (commit bd8810429a by @rerpha) |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
|
✅ Build pvAccessCPP 1.0.155 completed (commit 9d8653a336 by @rerpha) |
Adds a default message for pvget. I don't know if line 363 (the default case) was a bug as i could never get it to run. @ralphlange I found this after I showed you my (accidentally?) working PVAccess.
Maybe there's a good reason that pvget doesn't have this line but the other tools do, please let me know!