allow users to customize confirmed participations#1826
Open
Conversation
|
coverage: 81.356%. remained the same — customize-confirmed-participations into main |
jeriox
commented
Apr 20, 2026
| @@ -182,9 +182,19 @@ def __init__(self, *args, **kwargs): | |||
| FormActions(*self._get_buttons()), | |||
| ) | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
got a bit complex, we could also move that over to the validator e.g. as can_change_individual_times()
Member
There was a problem hiding this comment.
I would like to see that in the validator in case we introduce API-based signup, yes.
Alternatively, have you thought about replacing can_customize_signup as a can_change_individual_time and just always allowing people to open the customize form (if they can sign up or decline)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1599
keeping the behaviour that users can customize times if they are confirmed and can decline and re-signup. we could also think about dropping this (related to #620)