Skip to content

fix not programmed listeners for merge gateways#8744

Open
cnvergence wants to merge 5 commits intoenvoyproxy:mainfrom
cnvergence:fix-merge-gw-tls
Open

fix not programmed listeners for merge gateways#8744
cnvergence wants to merge 5 commits intoenvoyproxy:mainfrom
cnvergence:fix-merge-gw-tls

Conversation

@cnvergence
Copy link
Copy Markdown
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit b6f678d
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69eb86f49dea9b000962c1dd
😎 Deploy Preview https://deploy-preview-8744--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.44%. Comparing base (cab6837) to head (b6f678d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8744      +/-   ##
==========================================
+ Coverage   74.39%   74.44%   +0.04%     
==========================================
  Files         246      246              
  Lines       39221    39223       +2     
==========================================
+ Hits        29180    29199      +19     
+ Misses       8017     8003      -14     
+ Partials     2024     2021       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cnvergence cnvergence marked this pull request as ready for review April 22, 2026 15:56
@cnvergence cnvergence requested a review from a team as a code owner April 22, 2026 15:56
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be40f08593

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +296 to +297
if t.MergeGateways && !listener.IsReady() {
continue
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude non-ready listeners from TLS overlap checks

In merge-gateways mode this new continue drops non-programmed listeners from xDS generation, but checkOverlappingTLSConfig still iterates all HTTPS listeners from gateway.listeners (including non-ready ones) and can set TLSOverlaps on ready listeners. That causes internal/xds/translator/listener.go to force ALPN to http/1.1 for a listener that no longer has any overlapping peer in xDS, so valid HTTPS listeners can lose HTTP/2 unnecessarily whenever an overlapping listener is invalid/unprogrammed.

Useful? React with 👍 / 👎.

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant