feat: expose ignoreNewHostsUntilFirstHealthCheck in BackendTrafficPolicy#8631
feat: expose ignoreNewHostsUntilFirstHealthCheck in BackendTrafficPolicy#8631Aditya7880900936 wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
…icy health check Signed-off-by: Aditya7880900936 <adityasanskarsrivastav788@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| // | ||
| // This maps to Envoy's common_lb_config.ignore_new_hosts_until_first_hc. | ||
| // +optional | ||
| IgnoreNewHostsUntilFirstHealthCheck *bool `json:"ignoreNewHostsUntilFirstHealthCheck,omitempty"` |
There was a problem hiding this comment.
Any thoughts on a better name here?
There was a problem hiding this comment.
Good point, thanks for the suggestion!
I kept the name aligned with Envoy's field ignore_new_hosts_until_first_hc for clarity and easier mapping.
That said, I agree it might be a bit verbose. I'm open to renaming if you have a preferred convention (e.g., shorter or more user-friendly).
Happy to update based on your suggestion.
There was a problem hiding this comment.
hey @jukie , any further updated regarding this PR , how can i imorove the naming here
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8631 +/- ##
==========================================
- Coverage 74.33% 74.32% -0.02%
==========================================
Files 243 243
Lines 38147 38238 +91
==========================================
+ Hits 28358 28421 +63
- Misses 7801 7822 +21
- Partials 1988 1995 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
hi @jukie , is there any relevant naming convention for this PR , if it is i would like you to suggest me please so that i can proceed further with the PR |
This PR adds support for configuring
ignore_new_hosts_until_first_hcvia BackendTrafficPolicy active health checks.
When enabled, newly added endpoints will not receive traffic until they
pass their first health check. This prevents traffic from being sent to
unready backends and avoids 503/504 errors during rollouts.
Changes:
ignoreNewHostsUntilFirstHealthCheckFixed issue : #8597