리스트 5000개 초과 토스트를 alert에서 warning으로 변경#3068
Open
prisml wants to merge 1 commit into
Open
Conversation
- 기획팀(김유민) 요청으로 알림 수준을 warning으로 하향 조정 📋 - alert는 에러성 알림이므로 안내 목적의 warning이 더 적절 💡 - listVariable.js, variable_container.js 3곳 일괄 변경 🔧
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 문제 상황
Entry.toast?.alert()로 알림을 표시하고 있음alert는 에러성 알림에 사용되는 레벨이므로, 단순 안내 목적의 메시지에는 적절하지 않음✅ 해결 방안
1.
Entry.toast?.alert()→Entry.toast?.warning()으로 변경warning으로 하향 조정listVariable.js—_showListFullWarning()메서드variable_container.js— 리스트 길이 입력 onblur 핸들러variable_container.js— 리스트 항목 추가(plus) 버튼 핸들러🎯 예상 영향 범위
alert→warning으로 변경됨