feat(validator): add OSS-scoring round completion summary#1401
Open
Khaostica wants to merge 1 commit into
Open
feat(validator): add OSS-scoring round completion summary#1401Khaostica wants to merge 1 commit into
Khaostica wants to merge 1 commit into
Conversation
The issue-discovery phase logs a one-line summary after each round
("Issue discovery complete | N processed | ...") that lets an operator
see at a glance how the round went. The OSS-scoring phase had only the
flat "Finalization complete." line plus per-UID detail, with no
equivalent. This adds a matching summary reporting evaluated / eligible /
penalized (duplicate github) / cache-fallback / failed-validation counts.
Logging only -- no scoring state is changed.
4a8e327 to
d58304c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The issue-discovery phase closes each scoring round with a one-line summary (
Issue discovery complete | N processed | …inscan.py), but the OSS-scoring phase logs onlyFinalization complete.with no round-level aggregate. This change adds the matching completion summary so an operator can gauge a scoring round at a glance.Additive logging only: it reads
is_eligible/failed_reason(already set during finalization) plus thecached_uids/penalized_uidssets thatget_rewards()already holds. It only counts and prints values that already exist — no scoring logic runs, and no miner's score changes.Before — the OSS-scoring phase ended here, with no round-level summary:
After — a single summary line now follows it (the counts below are from an example round, included to show the format — not real validator output):
Related Issues
Closes #1400
Type of Change
Testing
Checklist