Skip to content

Propostal to use relay experimental - #118

Merged
thicodes merged 8 commits into
entria:masterfrom
thicodes:chore/relay-react-experimental
Nov 20, 2019
Merged

Propostal to use relay experimental#118
thicodes merged 8 commits into
entria:masterfrom
thicodes:chore/relay-react-experimental

Conversation

@thicodes

@thicodes thicodes commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

About UserList, will we add routes+preloadQuery in preparation or preparedloadQuery within itself?

@renanmav

renanmav commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

How would you preload the query?

sibelius
sibelius reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/web/src/App.tsx Outdated
sibelius
sibelius reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/web/src/ErrorBoundary.tsx Outdated
sibelius
sibelius reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/web/src/index.tsx
sibelius
sibelius reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/web/src/index.tsx
sibelius
sibelius approved these changes Nov 20, 2019
View reviewed changes

@sibelius sibelius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good first step

@thicodes

thicodes commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator Author

@renanmav
So, I thought of these 2 solutions:

  • Do inside the UserList. It is simpler, but it would be inappropriate.
  • Use routes - It would be closer to actual use as the issue-tracker.

What do you think?

@thicodes
thicodes merged commit 7ed1708 into entria:master Nov 20, 2019
@thicodes
thicodes deleted the chore/relay-react-experimental branch November 20, 2019 19:59
@renanmav

renanmav commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

Both solutions are valid. I prefer to preload on mouse hover.

@thicodes

thicodes commented Nov 20, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@renanmav
Great! Im going to create a package with an issue-tracker router abstraction and bring the routes, creating a new PR. Thanks!

@renanmav

renanmav commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

Actually I'm already working on this here with Typescript flow fede \o/

@thicodes

thicodes commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator Author

Wow. Very good!
Thank you very much. I will need a lot @renanmav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sibelius sibelius sibelius approved these changes
@AugustoCalaca AugustoCalaca Awaiting requested review from AugustoCalaca
@matheus1lva matheus1lva Awaiting requested review from matheus1lva
@miltoneiji miltoneiji Awaiting requested review from miltoneiji

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thicodes @renanmav @sibelius