ProductVersion reporting refactoring - #16
Merged
Merged
Conversation
… becomes a root module directory that depends on the library using a relative path. This should allows building using `go install`.
…irectory becomes a root module directory that depends on the library using a relative path. This should allows building using `go install`." This reverts commit 1988b83.
…RSION if build from source code outside of git. For example, when the source code is downloaded as a zip file.
… file are always in sync.
…ted in build when using `go install` command.
…ctVersionVerboseString()` to build package. Functions were also properly renamed.
…per` directory. - Created root package to embed the VERSION file content. - Modified `GetProductVersion()` to fall back to the content of file `/VERSION` if all other version identification method fails.
- Strip the leading "v" to only get the digits and pre-release labels when getting the fall back version from the tag name.
…l)". - Fixed failing test TestGetProductVersionStringContainsVERSIONFile()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(devel)was returned. Now falls back toVERSIONfile.Fixes #15.