[DEVEX-1523] Stop AI auto-approvals; comment-only with first-time Slack ping#128
Conversation
…d-have-approve The AI reviewer no longer submits formal GitHub approvals. The `approve` verdict now posts a `--comment` review with the wording "I would have approved this PR for the following reasons" so the AI's confidence is still visible without short-circuiting required human review. Slack notifications are de-duplicated to the first would-have-approved event per PR. A stable marker line on the comment body is queried via the reviews API to detect prior pings, so synchronize/re-run events do not spam the channel. Refs DEVEX-1523. Co-authored-by: Cursor <cursoragent@cursor.com>
PR SummaryLow Risk Overview The reviewer prompt and Slack notifies on the first would-have-approved run per PR by counting bot reviews whose bodies start with that marker (including the review just posted); later re-runs skip posting. Message copy shifts from “auto-approved” to “candidate for quick review.” Reviewed by Cursor Bugbot for commit d6e4e46. Bugbot is set up for automated code reviews on this repo. Configure here. |
Summary
Follow-up to DEVEX-1523. The AI reviewer no longer submits formal GitHub approvals — human review is always required. When the AI would have approved, it now posts a
--commentreview explaining why, and Slack is pinged only the first time per PR so humans see a quick-review candidate without channel spam on every push.What changed
approvearm of the apply-verdict step now usesgh pr review --comment. The body opens with the stable markerAI Review: Would have approved — human review still required.followed byI would have approved this PR for the following reasons:and the AI's reasoning.did_approve→would_have_approvedto reflect the new semantics.approvenow triggers a comment rather than a formal approval so calibration stays right.success(green) with title "AI would have approved" so the signal remains visible at a glance.Unchanged
commentanddeferarms, and Check Run publishing. Token permissions staypull-requests: write.Blast radius
Reusable workflow consumed via
@mainby encodium/radmin and encodium/manage. Both pick up the change on the next PR event after merge. This PR's own CI still runs the pre-merge workflow, so the new behavior is only observable on the next PR in a consumer repo.Test plan
--commentreview beginning with the marker line, no formal approval shows on the PR,AI Code Reviewcheck is green.commenton (real concerns) — confirm inline comments + neutral check, no Slack ping.Made with Cursor