Playtest fixes — event grouping, target-type toggle, cameo cap, RoundSummary#10
Merged
Conversation
…vents screen Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…unts Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🔴 Claude BugBot Analysis
Found 1 potential bug in this PR.
medium: 1
One bug found: the plan document's chump planner spec code omits the ?. optional chain operator when reading .alive from state.leaders[t], inconsistent with all other planners and risking a TypeError if any cast member's leader record is undefined. All other actual source code changes (cameo cap in resolution.ts, event grouping utilities, target-type retargeting in Planning.tsx, pickSubhead aggregation) are correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six fixes found while play-testing the Phase 4c slice 2 build — events display, launch targeting, and the round-summary "newspaper" page.
src/ui/util/eventGrouping.ts(groupPhaseEvents) counts builds per (leader, item) and renders "builds 3 small warheads". Aggregates by key rather than collapsing adjacent runs, so the human's interleaved build clicks group the same as the AI's item-groupedbuildTowardoutput.ImpactPeople/ImpactInfrastructurehits from one attacker on one target into a single "Carnage ─ 6M deaths (from IL)" line.targetTypeof launches already queued at that target, so a strike could land aspeopleafter the player switched toinfra. The toggle now retargets every queued launch for that leader.👥 25M · 🏭 8).Test Plan
npx tsc --noEmit— cleannpm run test:run— 298/298 pass across 43 files (13 new tests: event grouping, the target-type retarget, the cameo cap, the subhead summing)🤖 Generated with Claude Code