Fix zero-duration value animations returning the previous value - #8469
Open
cuishuang wants to merge 1 commit into
Open
Fix zero-duration value animations returning the previous value#8469cuishuang wants to merge 1 commit into
cuishuang wants to merge 1 commit into
Conversation
Signed-off-by: cuishuang <imcusg@gmail.com>
|
Preview is being built... Preview will be available at https://egui-pr-preview.github.io/pr/8469-fix-zero-duration-value-animation View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
animate_value_with_time returned the previous value for one frame when called with a zero duration because it calculated the current value before updating the animation target.
Handle zero-duration animations before interpolation so they immediately return and store the target value. Add a regression test covering consecutive target changes.