Fix deferred viewport repaint requests on Windows - #8467
Open
rustbasic wants to merge 6 commits into
Open
Conversation
Added viewport_window_kind function to determine the type of viewport window based on window_id.
|
Preview available at https://egui-pr-preview.github.io/pr/8467-p120 View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where deferred viewports may stop repainting after the root viewport receives focus on Windows.
When Windows does not deliver
RedrawRequestedevents, expired repaint requests for deferred viewports are painted directly.Direct painting uses a per-event-loop time budget rather than limiting processing to one viewport, allowing multiple deferred viewports to update while still yielding to root-window event processing.
deferred viewportdoes not redraw when clickingROOT viewport(Windows) #8351