[performance] Avoid cross-viewport GalleyCache eviction - #8418
Open
rustbasic wants to merge 8 commits into
Open
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8418-p116 View snapshot changes at kitdiff |
rustbasic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
Fontsto keepGalleyCacheentries partitioned by viewport.Previously, multiple viewports shared one galley cache. Since each viewport flushes the cache at the start of its pass, root and child viewports could repeatedly evict each other's text layouts.
As viewport text workload grows, this can force repeated layout of large text contents and cause severe performance degradation, with the frame rate dropping below 10 FPS in some cases.
Font data and the texture atlas remain shared. Only layout caches are separated by an opaque viewport namespace.
immediate viewportis on another screen #5249Galleys in root or deferred viewports #8419There is a possibility that #5836 and #7885 will also be resolved with this Pull Request.