use wasm version without having to change module.exports - #14
Closed
tinchoz49 wants to merge 1 commit into
Closed
Conversation
Author
|
#8 does what we need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some bundle tools like rollup and webpack try to convert commonjs to ESM. Since ESM cannot be change the exports dynamically we lost the oportunity of use the wasm version.
This PR add support to allow to use wasm without having to modify exports in the module system behind.
It's not a breaking change, it doesn't remove the action of modify the exports, it just add another option.