Block editor#4
Conversation
jacobischwartz
left a comment
jacobischwartz
left a comment
There was a problem hiding this comment.
Mostly code comment and escaping changes. Thanks @emfluenceindia!
| <?php | ||
|
|
||
| // Subrata | ||
| // add_filter( 'use_widgets_block_editor', '__return_false' ); |
There was a problem hiding this comment.
Let's remove the commented code 😉
| 'emfluence-emailer-widget' | ||
| ,plugins_url( '/js/widget-settings.min.js', __FILE__ ) | ||
| //Subrata | ||
| //,plugins_url( '/js/widget-settings.js', __FILE__ ) |
There was a problem hiding this comment.
Commented code to remove
| Description: Easily add forms to your website for contacts to add or update their details in your emfluence Marketing Platform account. | ||
| Author: emfluence Digital Marketing | ||
| Version: 2.13 | ||
| Version: 2.13.1 |
There was a problem hiding this comment.
Let's increase this to 2.14
|
|
||
| //Subrata | ||
| $groupIdsContainer = this.getGroupIdsContainer($widget); | ||
| //Subrata |
There was a problem hiding this comment.
Code comment to remove
|
|
||
| //Subrata | ||
| //console.log(values.id); | ||
| //Subrata |
There was a problem hiding this comment.
Code comments to remove
| $output .= $this->form_template_custom_variables($defaults, $instance); | ||
| $output .= $this->form_template_notification($instance); | ||
|
|
||
| //Subrata: new fld |
There was a problem hiding this comment.
Remove code comment
|
|
||
| // Output the datalist for groups just once | ||
| if( intval($this->number) == 0 ) { | ||
| // if( intval($this->number) == 0 ) |
There was a problem hiding this comment.
Remove commented code
| if( intval($this->number) == 0 ) { | ||
| // if( intval($this->number) == 0 ) | ||
| if( intval($this->number) >= 0 ) { // Subrata | ||
| $output .= '<input type="hidden" id="emfluence_email_signup_instance" value="' . $this->number . '" />'; |
There was a problem hiding this comment.
Escape variable in output
| } | ||
|
|
||
| // Clean up the free-form areas | ||
| // Subrata: new fld |
There was a problem hiding this comment.
Remove code comment
|
|
||
| // If the current user isn't allowed to use unfiltered HTML, filter it | ||
| if ( !current_user_can('unfiltered_html') ) { | ||
| // Subrata: new fld |
There was a problem hiding this comment.
Remove code comment
|
All changes are made. |
|
Hi Jacob, Regards, |
2 participants
Phase 1: Plugin fixes for block widget editor.
Version: 2.13.1
[ x ] Add: Two new fields added. Form name and Form ID. Section: Form Identification.
[ x ] Fix: Group search was not working.
[ x ] Fix: Group Add button was not working.
[ x ] Fix: Group removal (deselecting a previously added group) was not working.