install/build: require macOS 26 with a clear early error - #9
Merged
Conversation
install.sh checked Darwin + arm64 but not the OS version. maic needs FoundationModels (macOS 26+), so on older macOS the install succeeded and the binary then failed to launch with a cryptic dyld version error. Add a sw_vers guard to both install.sh and build.sh so they fail fast with 'requires macOS 26 or later (detected <ver>)' instead. Closes #8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
Problem
install.shcheckedDarwin+arm64but not the macOS version. maic needs FoundationModels (macOS 26+, perPackage.swift), so on macOS 25 or earlier the install succeeded and the binary then failed to launch with a cryptic dyld version error instead of a friendly, actionable message.Change
Add a
sw_vers-based guard to both scripts, failing fast before any network/build step:install.sh— immediately after the arm64 check, using the existingerr()helper.build.sh— beforeswift build, usingecho … >&2; exit 1(noerr()helper there).Fails safe: if
sw_versis missing or returns non-numeric/empty,[ "" -ge 26 ]errors (silenced via2>/dev/null) and the abort still fires.Verification
bash -n install.shandzsh -n build.shpass.sw_vers:15.5/25.9→ abort (exit 1) with the message, before any download/build;26.0/26.5.2/27.1→ proceed.swift run maicTests) green./code-review(standards + spec) came back clean.Out of scope: runtime availability messaging (already handled via
SystemLanguageModel.default.availability).