Skip to content

Update data_substrate for DSS drain gates - #530

Closed
thweetkomputer wants to merge 1 commit into
mainfrom
fix-dss-read-write-drain-gate
Closed

Update data_substrate for DSS drain gates#530
thweetkomputer wants to merge 1 commit into
mainfrom
fix-dss-read-write-drain-gate

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Updates the data_substrate submodule to include the DataStoreService drain gate fix from:

  • eloqdata/tx_service#521
  • f6082b3 Fix DSS drain gates

Details

The submodule update brings in:

  • sequentially consistent write gate/drain ordering for ReadWrite -> ReadOnly;
  • read/scan submit-window draining before ReadOnly -> Closed calls backend Shutdown();
  • the latest eloqstore main pointer used by the tx_service change.

This root PR intentionally only moves the data_substrate gitlink so eloqkv can consume the validated submodule change.

Validation

  • cmake --build bld-eloqstore-local --target eloqkv -j2

Summary by CodeRabbit

  • Chores
    • Updated the data substrate component to a newer revision.
    • No user-facing feature or behavior changes.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3365ab11-e72c-4a12-b845-2fe33b6682b0

📥 Commits

Reviewing files that changed from the base of the PR and between f62482c and 11de874.

📒 Files selected for processing (1)
  • data_substrate
🚧 Files skipped from review as they are similar to previous changes (1)
  • data_substrate

Walkthrough

The data_substrate subproject commit pointer is updated from 9cd8840d to 631a8b22. No public declarations or repository code are changed.

Changes

Substrate revision

Layer / File(s) Summary
Subproject revision update
data_substrate
The recorded data_substrate commit reference is updated to 631a8b2286eeca62897512cce833781f9b7f50d7.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: trigger-ci

Suggested reviewers: liunyl, lzxddz, mrguin, zhangh43, starrysky9959

Poem

A bunny checks the pointer bright,
From one small hash to one in sight.
No code hops, no branches sway,
Just substrate marching on its way.
- 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the data_substrate submodule for DSS drain gate fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-dss-read-write-drain-gate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thweetkomputer
thweetkomputer force-pushed the fix-dss-read-write-drain-gate branch from 47ce563 to a6d9c3f Compare July 13, 2026 05:33
@CLAassistant

CLAassistant commented Jul 13, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@thweetkomputer
thweetkomputer force-pushed the fix-dss-read-write-drain-gate branch from a6d9c3f to f62482c Compare July 13, 2026 05:34
@thweetkomputer

Copy link
Copy Markdown
Collaborator Author

I have performed a benchmark on an 8-core ARM VM. No degradation is found.

@thweetkomputer
thweetkomputer marked this pull request as ready for review July 13, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants