Update data_substrate for DSS drain gates - #530
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe ChangesSubstrate revision
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
47ce563 to
a6d9c3f
Compare
a6d9c3f to
f62482c
Compare
|
I have performed a benchmark on an 8-core ARM VM. No degradation is found. |
f62482c to
11de874
Compare
Summary
Updates the
data_substratesubmodule to include the DataStoreService drain gate fix from:eloqdata/tx_service#521f6082b3 Fix DSS drain gatesDetails
The submodule update brings in:
ReadWrite -> ReadOnly;ReadOnly -> Closedcalls backendShutdown();eloqstoremainpointer used by thetx_servicechange.This root PR intentionally only moves the
data_substrategitlink soeloqkvcan consume the validated submodule change.Validation
cmake --build bld-eloqstore-local --target eloqkv -j2Summary by CodeRabbit