fix: update data_substrate — prevent dirty_data_key_count_ underflow - #458
fix: update data_substrate — prevent dirty_data_key_count_ underflow#458githubzilla wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ec5f92a to
da92602
Compare
51d2453 to
9831b0f
Compare
…erflow Update data_substrate submodule to include the fix for an intermittent assertion failure in AdjustDataKeyStats where dirty_data_key_count_ underflows during cluster scale-out. See eloqdata/tx_service#465 for details.
6cd7387 to
49f0dcf
Compare
Summary
Update data_substrate submodule to include fix for intermittent assertion failure:
Three bugs fixed in tx_service (see eloqdata/tx_service#465 for full details):
CanBeCleanednow checks!GetBeingCkpt()to prevent dirty count double-decrement (confirmed root cause via core dump + diagnostic logs)SetCommitTsPayloadStatusbeforeSetCkptTsto prevent flush bit from being cleared; added missingOnCommittedUpdatein BackFill and ReadOutsideCc pathsSetCommitTsPayloadStatussitesTesting
Verified by running
cluster_scale_test.py(all 5 tests) dozens of times with no assertion failures.Summary by CodeRabbit