fix(i18n): use correct defaultLocale when domains array is present on default host - #25
Open
hbrooks wants to merge 3 commits into
Open
fix(i18n): use correct defaultLocale when domains array is present on default host#25hbrooks wants to merge 3 commits into
hbrooks wants to merge 3 commits into
Conversation
… default host When a `domains` array is configured in i18n and the request is served from the default domain (e.g., localhost), `defaultLocale` was incorrectly set to a configured domain's value because `detectDomainLocale` matched on the detected locale rather than hostname. Remove `domainLocale?.defaultLocale` from the fallback chain in `RouteModule.prepare()` since `base-server.ts` already sets the correct value in request metadata via hostname-only matching. Fixes vercel#90131
Adds /go-BE and /do-BE cases that exercise the item.locales match branch of detectDomainLocale (distinct from the defaultLocale match), verifying the request defaultLocale stays en-US on the default host.
|
@hbrooks Let me know If you need anything from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally PR vercel#93151 in vercel/next.js by @hammadxcm