Add writeIniFile() for song.ini emission - #69
Open
elicwhite wants to merge 1 commit into
Open
Conversation
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 20, 2026
elicwhite
marked this pull request as ready for review
April 20, 2026 04:16
elicwhite
force-pushed
the
create-empty-chart
branch
from
April 20, 2026 04:16
1d776fe to
dbef712
Compare
elicwhite
force-pushed
the
write-ini-file
branch
from
April 20, 2026 04:17
6bd889d to
7545ae1
Compare
elicwhite
force-pushed
the
create-empty-chart
branch
from
April 20, 2026 04:40
dbef712 to
60fcd5e
Compare
elicwhite
force-pushed
the
write-ini-file
branch
2 times, most recently
from
April 20, 2026 04:45
6791016 to
4993c9b
Compare
elicwhite
force-pushed
the
create-empty-chart
branch
from
April 20, 2026 04:45
60fcd5e to
42d80e2
Compare
This was referenced Apr 20, 2026
elicwhite
force-pushed
the
create-empty-chart
branch
from
April 20, 2026 05:09
42d80e2 to
c28bbd2
Compare
elicwhite
force-pushed
the
write-ini-file
branch
from
April 20, 2026 05:09
4993c9b to
c983ac5
Compare
elicwhite
force-pushed
the
create-empty-chart
branch
from
April 20, 2026 05:10
c28bbd2 to
c6f1e16
Compare
elicwhite
force-pushed
the
write-ini-file
branch
2 times, most recently
from
April 20, 2026 05:19
9a075ab to
6826cfb
Compare
elicwhite
force-pushed
the
create-empty-chart
branch
from
April 20, 2026 05:19
c6f1e16 to
0b28f17
Compare
This was referenced Apr 20, 2026
This was referenced Apr 20, 2026
elicwhite
commented
Apr 21, 2026
Geomitron
approved these changes
Apr 21, 2026
elicwhite
force-pushed
the
write-ini-file
branch
from
April 21, 2026 04:29
6826cfb to
c6a264e
Compare
elicwhite
force-pushed
the
create-empty-chart
branch
2 times, most recently
from
April 21, 2026 05:06
531bbdf to
a3c4753
Compare
elicwhite
force-pushed
the
write-ini-file
branch
from
April 21, 2026 05:06
c6a264e to
3fbc70b
Compare
elicwhite
commented
Apr 21, 2026
elicwhite
force-pushed
the
write-ini-file
branch
2 times, most recently
from
April 21, 2026 16:38
cd27523 to
55a24bd
Compare
elicwhite
force-pushed
the
create-empty-chart
branch
from
April 21, 2026 16:51
a3c4753 to
d6f9c4f
Compare
elicwhite
force-pushed
the
write-ini-file
branch
from
April 21, 2026 16:51
55a24bd to
a269bd0
Compare
Serializes IniMetadata (Partial<typeof defaultMetadata> + extraIniFields) back to song.ini text with: - [song] header - Known fields emitted in the canonical defaultMetadata order - Undefined values skipped - Booleans as True/False (Clone Hero convention) - extraIniFields appended in insertion order - CRLF line endings Derives its field order from Object.keys(defaultMetadata) rather than hardcoding a separate FIELD_ORDER list, so new fields added to defaultMetadata automatically participate in writing. Tests exercise writeIniFile only via round-trip through parseChartAndIni, per reviewer feedback: build a metadata object, write it, re-parse, and assert on parsedChart.metadata. No assertions about the serialized ini text itself (CRLF, field order, True/False formatting, quoting) — those are implementation details.
elicwhite
force-pushed
the
create-empty-chart
branch
from
April 21, 2026 23:18
d6f9c4f to
84b0e83
Compare
elicwhite
force-pushed
the
write-ini-file
branch
from
April 21, 2026 23:18
a269bd0 to
75b92a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializes IniMetadata (Partial + extraIniFields)
back to song.ini text with:
Derives its field order from Object.keys(defaultMetadata) rather than
hardcoding a separate FIELD_ORDER list, so new fields added to
defaultMetadata automatically participate in writing.