Wizard: whole-library classify scope#24
Merged
Merged
Conversation
The wizard's classify stage was hardcoded to new/changed books (select.changed)
and dead-ended with "nothing to tag" when nothing had changed — there was no way
to re-tag the whole library short of the CLI. Open the stage with a scope menu:
new/changed (the cheap default) or whole library (a full pass), still offered
when nothing's changed.
classify gains an --all scope (reusing select.pick("all")) so the CLI has the
same capability and the wizard just sets a.all. The €50 guard is unchanged: the
engine menu prices the chosen scope, the non-apple send is gated by the existing
confirm, and apple (free) stays the default engine — a full paid pass is never
the default. test_core pins that --all is opt-in (bare classify is never
whole-library).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The wizard's classify stage was locked to new/changed books and dead-ended when nothing had changed. It now opens with a scope menu:
The whole-library option is offered even when nothing's changed (where it previously just said "nothing to tag ✓").
classify --all— new scope flag reusingselect.pick("all"), so the CLI gains the same capability; the wizard just setsa.all.send 1,847 books to the gemini API (~$X)?), and apple (free) stays the default engine. A full paid pass is never the default.Test
test_corepins the safety invariant —--allis opt-in, a bare classify is never whole-library. All 8 suites pass (test_core now 43).🤖 Generated with Claude Code