Phase 3: type annotations + wizard/ui tests#18
Merged
Conversation
Extend the type hints from the five high-fan-in seams to the rest of the public functions in common, select, staleness, promote, classify — plus the two largest engine modules (wrangle, overrides) so type_safety improves holistically, not just in the modules the issue named. Plain honest hints (dict / list / tuple / X | None / argparse.Namespace), no typing gymnastics; this also clears the 'loose type annotation' smells. No behavior change; full suite green. Refs #12. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…tion helpers wizard.py and ui.py were the last untested production files. Test only the pure helpers where a regression can actually ship: _task_hint (the pending-work menu markers), _engines (cloud-engine-usable-iff-key-in-env + hints), and the proposal pending/to_stamp split — extracted from snapshot() into a pure _proposal_counts() so it's testable without a live library. The rich-interactive shells (menus, prompts, live dashboard) are left untested by design. Closes #13. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of the desloppify code-health roadmap. Three commits, all low-risk, full suite green.
#12 — annotate the public surface (
64b7350)Extended plain, honest type hints from the five high-fan-in seams to the rest of the public functions in
common,select,staleness,promote,classify— and the two largest engine modules (wrangle,overrides) so thetype_safetydimension improves holistically. Hints aredict/list/tuple/X | None/argparse.Namespace— notypinggymnastics — which also clears the "loose type annotation" smells. No behavior change.Banked improvement: a blind, context-isolated re-review of
type_safety(scored from code evidence only, no target/score anchoring) moved the dimension 62.0 → 82.0. It also filed 3 honest follow-up defects (bare container returns hide real shape in docstrings; the engine-dispatch protocol is untyped;ui.py/wizard.pyinteractive layer is largely unannotated) — candidates for a later pass, not blockers.#13 — test the pure wizard/ui helpers (
4e16f50)wizard.pyandui.pywere the last untested production files. Addedtests/test_wizard.pycovering the pure helpers where a regression can actually ship:_task_hint(the pending-work menu markers),_engines(cloud-engine-usable-iff-key-in-env + hints), and the proposal pending/to_stamp split — extracted fromsnapshot()into a pure_proposal_counts()so it's testable without a live library. The rich-interactive shells (menus, prompts, live dashboard) are left untested by design. Wired intoci.yml.Net score movement (local desloppify, strict)
82.3 → 83.9— objective rose (Test health 55.5% → 72.4% from the new tests + the Phase-2 wrangle split), andtype_safetyre-review added the rest.🤖 Generated with Claude Code