🧪 refresh the Linux persona tie baseline - #683
Merged
Merged
Conversation
The tie-resolution copy changed in 21caf81 (#668), which refreshed the darwin baseline but not the Linux one, so every develop run now fails the visual contract on features-persona-onboarding-states--resolution. The baseline is replaced with the rendering CI itself produced for that story; no component or story changed here. The break went unnoticed because the Storybook steps used to run inside the test job and earlier guard failures stopped the job before reaching them. They now run as their own parallel job and report independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every develop run is currently red on the Storybook visual contract for
features-persona-onboarding-states--resolution, which blocks image publication and therefore any deploy.The tie-resolution copy changed in
21caf818("⚡ explain persona tie choices", #668): the heading, the option labels (Analyst (Blue)/Anchor (Green)), their descriptions, and the button text. That commit refreshed the darwin baseline at 10:19 today but left the Linux baseline untouched — it was last written on 10 August. Only CI can generate the Linux rendering, which is why the gap is easy to miss locally.Evidence: the failing run's own diff shows old copy versus new copy, not anti-aliasing noise (3% of pixels, all text and control labels), and the
-actual.pngrender is clean and complete.What
The Linux baseline is replaced with the exact rendering CI produced for that story. No component, story, or test changed — this is a baseline refresh only, matching the precedent in
🧪 refresh Linux onboarding visual contractsand🧪 align Linux welcome snapshots.Why it surfaced now
The Storybook steps used to run inside the
testjob, after ~15 policy guards. On the develop runs since #668 merged, the job failed at an earlier guard and never reached the visual tests, so the stale baseline stayed hidden. #677 moved Storybook into its own parallel job, so it now reports independently — this is that change doing its job on its first day.Unblocks
Develop CI → image publication for the current develop head → the pending
testv4.dev.opencrane.aideploy.