⚡ derive umbrella subchart packaging from in-repo sources - #681
Closed
jrosseel wants to merge 1 commit into
Closed
Conversation
Every umbrella dependency is a file:// chart in this repository, so the checked-out commit already fixes the exact sources. The umbrella now declares open version constraints and the deploy fixture packages the current sources at render time; the checked-in Chart.lock and vendored archives are gone, and a chart version bump no longer requires touching the umbrella at all. The release gate keeps the one invariant that can still drift: every chart-bearing application must stay declared as an umbrella dependency.
jrosseel
marked this pull request as draft
August 19, 2026 13:16
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #677 (merge that first; this PR then retargets to develop automatically).
Why
Every subchart version bump forced three synchronized edits — the umbrella
Chart.yamlpin,Chart.lock, and the vendoredcharts/*.tgz— and a missed one blocked CI/deploys (the exact failure mode flagged on #677's review pass). All 15 umbrella dependencies are in-repofile://charts, so the checked-out commit already fixes their exact sources: the pin ceremony recorded no information git didn't already hold.What
">=0.0.0-0") — it always accepts whatever version the owning app's chart currently declares.Chart.lockand the vendoredcharts/*.tgzare deleted and gitignored; the deploy fixture (current-chart-sources.sh) packages the current sources withhelm dependency update --skip-refreshat render time, exactly as the contract checks now do.validateUmbrellakeeps the one invariant that can still drift — every chart-bearing application must stay declared as an umbrella dependency — and drops the pin/lock/archive comparisons (the packaging-diff checker is deleted with them).post-deploy-health-contract.shrenders from the shared fixture instead of hand-packaging four charts around the committed archives.Validation
check:release-versioning --base origin/developPASS; versioning tests 49/49 (umbrella test rewritten for the membership invariant)