🐛 Refresh login session after Zitadel login return - #635
Open
josphat-otieno wants to merge 5 commits into
Open
Conversation
… fix/login-session-refresh
…t-otieno/opencrane into fix/login-session-refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the login page so OpenCrane refreshes the session when the browser returns from external Zitadel authentication and redirects authenticated users to
/immediately.Changes
/auth/mewhen the login page loadspageshow,focus, andvisibilitychangeDestroyRefWhy
Users could successfully authenticate in Zitadel and still remain on
/loginuntil another action refreshed the session. This makes the login page resilient to that return flow.