[agents][incident flup] wait for server side agent to join remove before snending data#642
Open
AngeloGiacco wants to merge 1 commit into
Open
[agents][incident flup] wait for server side agent to join remove before snending data#642AngeloGiacco wants to merge 1 commit into
AngeloGiacco wants to merge 1 commit into
Conversation
Member
|
I've been unable to reproduce the original issue, so I can't reliably determine if this will fix it. To clarify: You mostly just want me to validate that this doesn't break stuff? As I see it this change will add the agent's connection to the critical path of starting a session, right? That's not ideal and should be avoided if we'd want to keep things fast and responsive 😬 |
Collaborator
Author
|
would be great yeah :) i dont have rn set up so would like to check it doesnt cause any issues there but otherwise i will get round to it later this week, can always just QA on js otherwise |
Collaborator
Author
|
btw i dont think this would have actually prevented the incident, it was definitely the livekit bug, just looks safer to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i think we can add this for extra safety as a flup to the incident, logic looks reasonable to me. could you take it for a spin locally and see if it works well @kraenhansen ?
Note
Medium Risk
Adds a new pre-send wait/timeout in the WebRTC connection handshake, which could delay or fail connection setup if participant events/identities differ from expectations.
Overview
Prevents WebRTC conversation init messages from being dropped by waiting for a remote participant whose
identitycontainsagentto appear (either already inroom.remoteParticipantsor viaRoomEvent.ParticipantConnected) before sending the initiation/overrides payload, with a 30s timeout.Updates the LiveKit mocks in
WebRTCConnection.test.tsto includeremoteParticipantsand theParticipantConnectedevent so tests align with the new handshake behavior.Written by Cursor Bugbot for commit 76bb8ce. This will update automatically on new commits. Configure here.