add voiceIsolation to WebRTC#487
Open
AngeloGiacco wants to merge 1 commit into
Open
Conversation
AngeloGiacco
force-pushed
the
add-voice-isolation-webrtc
branch
from
January 31, 2026 23:57
11398b9 to
4b1c062
Compare
PaulAsjes
requested changes
Feb 2, 2026
| // Track mock calls using a global object that can be accessed after mocking | ||
| const mockCalls = { | ||
| setMicrophoneEnabled: [] as boolean[], | ||
| createLocalAudioTrack: [] as unknown[], |
Collaborator
There was a problem hiding this comment.
Can we use proper types instead of unknown?
|
|
||
| // Create constraints for the new input device | ||
| const audioConstraints: MediaTrackConstraints = { | ||
| const audioConstraints = { |
| // Enable microphone only if not text-only mode | ||
| if (!config.textOnly) { | ||
| await room.localParticipant.setMicrophoneEnabled(true); | ||
| const audioConstraints = { |
Collaborator
There was a problem hiding this comment.
Since this is duplicated below, can we extract this? Also are we sure that setMicrophoneEnabled doesn't already do this?
kraenhansen
removed their request for review
March 12, 2026 08:12
Member
|
Removed myself as reviewer to avoid reminders, feel free to add me back when / if it's considered ready for review 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-
voiceIsolation: truewas already enabled for WebSocket connections (ininput.ts)-WebRTC was missing this because it uses LiveKit's APIs instead of the shared
Inputclass-This PR adds
voiceIsolationto WebRTC for both initial mic setup and device switching