Skip to content

Update elementor version logic#647

Open
hein-obox wants to merge 2 commits into
mainfrom
internal/TMZ-1038-update-elementor-download
Open

Update elementor version logic#647
hein-obox wants to merge 2 commits into
mainfrom
internal/TMZ-1038-update-elementor-download

Conversation

@hein-obox
Copy link
Copy Markdown
Member

@hein-obox hein-obox commented May 21, 2026

✨ PR Description

1. Problem & Context

Elementor version handling was hardcoded to WordPress.org releases; this refactors to support GitHub artifacts for development branches (like main), enabling testing against unreleased builds. TMZ-1038.

2. What Changed (Where)

File Change
.github/scripts/download-elementor-core.sh New 139-line script handling WordPress.org GA + GitHub artifact downloads with token validation
.github/workflows/playwright-with-specific-elementor-version.yml Extract download logic, add install-source output, verify token before download
.github/workflows/playwright-with-specific-hello-plus-version.yml Mirror token verification & script invocation; require CLOUD_DEVOPS_TOKEN secret
.github/scripts/daily-report.js New formatElementorReportLabel() & formatTestDisplayName() functions for consistent version labeling
.github/workflows/playwright.yml Fix token env var syntax (NODE_AUTH_TOKEN:NODE_AUTH_TOKEN:)

3. How It Works

Download script branches on version format: latest-stable / semantic X.Y.Z → WordPress.org ZIP; anything else (e.g., main) → GitHub Actions artifact via API with bearer token. Token verified upfront; outputs effective-version and install-source for downstream reporting. Report functions normalize Elementor labels across test names (GitHub vs WordPress.org sources flagged distinctly).

4. Risks

Token scope: CLOUD_DEVOPS_TOKEN needs elementor/elementor repo read access; workflows fail silently if secret undefined. Artifact chaining: download script runs in build job, artifacts propagate to test jobs—structural breakage risks fallback removal. Syntax error: NODE_AUTH_TOKEN:${{ secrets...}} missing space before value (line 40, .github/workflows/playwright.yml), will evaluate to literal string, not secret injection.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant