Update elementor version logic#647
Open
hein-obox wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Elementor version handling was hardcoded to WordPress.org releases; this refactors to support GitHub artifacts for development branches (like
main), enabling testing against unreleased builds. TMZ-1038.2. What Changed (Where)
.github/scripts/download-elementor-core.sh.github/workflows/playwright-with-specific-elementor-version.ymlinstall-sourceoutput, verify token before download.github/workflows/playwright-with-specific-hello-plus-version.ymlCLOUD_DEVOPS_TOKENsecret.github/scripts/daily-report.jsformatElementorReportLabel()&formatTestDisplayName()functions for consistent version labeling.github/workflows/playwright.ymlNODE_AUTH_TOKEN:→NODE_AUTH_TOKEN:)3. How It Works
Download script branches on version format:
latest-stable/ semanticX.Y.Z→ WordPress.org ZIP; anything else (e.g.,main) → GitHub Actions artifact via API with bearer token. Token verified upfront; outputseffective-versionandinstall-sourcefor downstream reporting. Report functions normalize Elementor labels across test names (GitHub vs WordPress.org sources flagged distinctly).4. Risks
Token scope:
CLOUD_DEVOPS_TOKENneeds elementor/elementor repo read access; workflows fail silently if secret undefined. Artifact chaining: download script runs in build job, artifacts propagate to test jobs—structural breakage risks fallback removal. Syntax error:NODE_AUTH_TOKEN:${{ secrets...}}missing space before value (line 40,.github/workflows/playwright.yml), will evaluate to literal string, not secret injection.Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how