Skip to content

Internal: Update Hello Theme daily test workflow [TMZ-1028]#635

Merged
hein-obox merged 2 commits into
mainfrom
internal/TMZ-1028-update-daily-tests
May 20, 2026
Merged

Internal: Update Hello Theme daily test workflow [TMZ-1028]#635
hein-obox merged 2 commits into
mainfrom
internal/TMZ-1028-update-daily-tests

Conversation

@hein-obox
Copy link
Copy Markdown
Member

@hein-obox hein-obox commented May 20, 2026

✨ PR Description

1. Problem & Context

Simplifies test workflow by unconditionally skipping a known-failing test instead of applying conditional logic based on test source type (TMZ-1028).

2. What Changed (Where)

.github/workflows/playwright-with-specific-hello-plus-version.yml: Removed conditional branch check; now always inverts grep for the "Quick Links" test.

3. How It Works

Previously skipped the failing test only when not running against main branch. Now always skips it, removing unnecessary conditional complexity.

4. Risks

Test may pass on main branch but fail in production if the issue isn't actually fixed—lost visibility into main-branch regression. Mitigation: Monitor test results separately.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@hein-obox hein-obox requested a review from nicoladj77 May 20, 2026 14:03
@hein-obox hein-obox merged commit 988ee33 into main May 20, 2026
42 of 43 checks passed
@hein-obox hein-obox deleted the internal/TMZ-1028-update-daily-tests branch May 20, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants