Internal: Update workflows hello theme tests [TMZ-1028]#632
Merged
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
nicoladj77
approved these changes
May 18, 2026
hein-obox
pushed a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Hello Theme workflow tests need to validate compatibility with Elementor Core versions, not just Hello Plus. Existing tests hardcoded
latest-stableElementor; this PR makes it configurable and refactors duplicate extraction logic into a reusable action.2. What Changed (Where)
.github/scripts/workflow-trigger.jselementor_core_branchinput; cleaned up emoji logging..github/actions/extract-hello-theme-zip/action.yml.github/workflows/daily-test-matrix.ymlelementor_versionalongsidehello_plus_version; removed stale comments..github/workflows/playwright-with-specific-hello-plus-version.ymlelementor_core_branchinput; added Elementor download step; removed complex version checkout/restore logic..github/workflows/playwright-with-specific-elementor-version.yml3. How It Works
Plus workflow now accepts optional
elementor_core_branchparameter (defaults tolatest-stable). Build job downloads Elementor from WordPress.org or uses GitHub releases formainbranch (fallback to latest-stable for unimplemented branches). Extraction logic centralized in composite action with better error handling (validatesstyle.cssexists, cleans staging directory). Workflow dispatch retry handles older target workflows that don't yet accept the new input—catches "unexpected inputs" error and retries withoutelementor_core_branch.4. Risks
Minor: Elementor
mainbranch downloads default tolatest-stablerather than building from source—won't detect main-only breaking changes until release. Composite action assumestmp/tree isolation; concurrent jobs in same runner could collide if temp cleanup fails. Plus matrix now requires Elementor input propagation through test jobs; missing env var would silently default test to latest-stable.Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how