Skip to content

Internal: Update workflows hello theme tests [TMZ-1028]#632

Merged
hein-obox merged 2 commits into
mainfrom
internal/TMZ-1028-update-workflow-2
May 18, 2026
Merged

Internal: Update workflows hello theme tests [TMZ-1028]#632
hein-obox merged 2 commits into
mainfrom
internal/TMZ-1028-update-workflow-2

Conversation

@hein-obox
Copy link
Copy Markdown
Member

@hein-obox hein-obox commented May 18, 2026

✨ PR Description

1. Problem & Context

Hello Theme workflow tests need to validate compatibility with Elementor Core versions, not just Hello Plus. Existing tests hardcoded latest-stable Elementor; this PR makes it configurable and refactors duplicate extraction logic into a reusable action.

2. What Changed (Where)

File Change
.github/scripts/workflow-trigger.js Added retry logic for workflows that don't declare elementor_core_branch input; cleaned up emoji logging.
.github/actions/extract-hello-theme-zip/action.yml New composite action; extracted 25-line inline bash script used in 3 places.
.github/workflows/daily-test-matrix.yml Fixed Plus matrix to pass elementor_version alongside hello_plus_version; removed stale comments.
.github/workflows/playwright-with-specific-hello-plus-version.yml Added elementor_core_branch input; added Elementor download step; removed complex version checkout/restore logic.
.github/workflows/playwright-with-specific-elementor-version.yml Replaced inline extraction with new action.

3. How It Works

Plus workflow now accepts optional elementor_core_branch parameter (defaults to latest-stable). Build job downloads Elementor from WordPress.org or uses GitHub releases for main branch (fallback to latest-stable for unimplemented branches). Extraction logic centralized in composite action with better error handling (validates style.css exists, cleans staging directory). Workflow dispatch retry handles older target workflows that don't yet accept the new input—catches "unexpected inputs" error and retries without elementor_core_branch.

4. Risks

Minor: Elementor main branch downloads default to latest-stable rather than building from source—won't detect main-only breaking changes until release. Composite action assumes tmp/ tree isolation; concurrent jobs in same runner could collide if temp cleanup fails. Plus matrix now requires Elementor input propagation through test jobs; missing env var would silently default test to latest-stable.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@wiz-9a149474ff
Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 1 Medium
Software Management Finding Software Management Findings -
Total 1 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@hein-obox hein-obox merged commit 2957151 into main May 18, 2026
50 checks passed
@hein-obox hein-obox deleted the internal/TMZ-1028-update-workflow-2 branch May 18, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants