ScreenCast: follow spec naming#191
Merged
Merged
Conversation
tl;dr: follow x-d-p spec Long version: By default vala translates dbus members from snake case to pascal case, and that's totaly ok for most of the time. But this behaviour bites us here since x-d-p expects `version` property to be lowercase. Before x-d-p 1.21 it wasn't an issue because they've set their version independently from us. But now they conditionally bind portal's properties to implementations (us). Since cursor capture was added with version 2, this all caused a missmatch of properties and confusion of clients, because we were reporting correct `AvailableCursorModes` but portal didn't know about this assuming we "supported" old version of the spec.
Member
|
Hi @garaevdi Could You drop a link to the spec? |
Contributor
Author
Sure Also screenshot portal does the same thing: portals/src/Screenshot/Portal.vala Lines 26 to 27 in c5f6fa1 |
leolost2605
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: follow x-d-p spec
Long version: By default vala translates dbus members from snake case to pascal case, and that's totally ok for most of the time. But this behavior bites us here since x-d-p expects
versionproperty to be lowercase. Before x-d-p 1.21 it wasn't an issue because they've set their version independently from us. But now they conditionally bind portal's properties to implementations (us). Since cursor capture was added with version 2, this all caused a mismatch of properties and confusion of clients, because we were reporting correctAvailableCursorModesbut portal didn't know about this assuming we "supported" old version of the spec.