Drop broken GIR namespace directive#967
Open
bugaevc wants to merge 5 commits into
Open
Conversation
GIR doesn't quite support multiple namespace nodes inside the same GIR file. I don't believe having a separate GraniteServices.gir was ever the intention here, nor is it really possible. Removing this, coupled with https://gitlab.gnome.org/GNOME/vala/-/merge_requests/449 on the Vala side, makes the GIR for libgranite actually useable. Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Member
|
@davidmhewitt I know you were working on Granite and you're maintaining Rust bindings, could you please advice/review? |
Author
|
How do we move this forward? |
Member
|
@danirabbit maybe you'll be able to help? |
Member
|
This line seemed to be added in #288. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: I'm hacking on Vala GIR generation (see https://gitlab.gnome.org/GNOME/vala/-/merge_requests/449). This line here is breaking things.
GIR doesn't quite support multiple
namespacenodes inside the same GIR file. I don't believe having a separateGraniteServices.girwas ever the intention here, nor is it really possible.The version bump to 9 is the high time to fix it.