Skip to content

SearchView: use GridView#2325

Merged
danirabbit merged 5 commits into
mainfrom
danirabbit/search-grid
Sep 4, 2025
Merged

SearchView: use GridView#2325
danirabbit merged 5 commits into
mainfrom
danirabbit/search-grid

Conversation

@danirabbit

@danirabbit danirabbit commented Aug 30, 2025

Copy link
Copy Markdown
Member

Sets us up for #2272

Screenshot from 2025-09-02 13 22 26

@danirabbit

This comment was marked as resolved.

@leolost2605

leolost2605 commented Sep 2, 2025

Copy link
Copy Markdown
Member

@danirabbit grid view has to be directly inside a scrolled window otherwise these weird bugs appear. This also makes sense because otherwise there would be no advantage of using grid view regarding performance since it won't know which children are visible.
See: https://gitlab.gnome.org/GNOME/gtk/-/issues/6801#note_2148413
I came across the same thing when trying to do the kinda the same😅

@danirabbit

Copy link
Copy Markdown
Member Author

Oh okay damn. I guess we will have to sacrifice the clamp then haha

@leolost2605

Copy link
Copy Markdown
Member

@danirabbit I started to work on a kind of scrollable pass through a while back that can handle this but idk if that will ever work reliably and I currently don't have a lot of time to work on it 🤷

@danirabbit

Copy link
Copy Markdown
Member Author

Yeah I think there's other things I can do instead anyways, like clamp the contents of a search item row and set max columns in the grid

@danirabbit danirabbit requested a review from a team September 2, 2025 20:27
@danirabbit danirabbit marked this pull request as ready for review September 2, 2025 20:28

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test rn but code lgtm

@danirabbit danirabbit enabled auto-merge (squash) September 4, 2025 13:55
@danirabbit danirabbit disabled auto-merge September 4, 2025 14:14
@danirabbit danirabbit merged commit 214425b into main Sep 4, 2025
6 of 12 checks passed
@danirabbit danirabbit deleted the danirabbit/search-grid branch September 4, 2025 14:14
@GeopJr

GeopJr commented Sep 4, 2025

Copy link
Copy Markdown

There's Adw.ClampScrollable specifically for this use-case!

@danirabbit

Copy link
Copy Markdown
Member Author

There's Adw.ClampScrollable specifically for this use-case!

Omg thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants