Reflect out-of-band leaves in MSC4222 state_after on sync#19957
Open
ara4n wants to merge 2 commits into
Open
Conversation
Out-of-band membership events are outliers: they never enter the current state delta stream, and the archived-room branch of sync deliberately returns no state for them. Clients using MSC4222's state_after do not apply timeline events to state, so without this they never learn that an invite rejection or knock rescission changed their membership, and e.g. Element Web keeps showing a knock as pending after rescinding it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uk8aPxHn3BHCe52L226jdG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out-of-band membership events are outliers which never enter the current state delta stream.
Clients using MSC4222's state_after do not apply timeline events to state, so without this they never learn that an invite rejection or knock rescission changed their membership, and e.g. Element Web keeps showing a knock as pending after rescinding it.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.