Push relevant users if there's a knock on a room (MSC4506)#19955
Open
ara4n wants to merge 3 commits into
Open
Conversation
Adds the recipient_permission push rule condition (unstable kind org.matrix.msc4506.recipient_permission): matches iff the user the rules are being evaluated for has a power level >= that required to perform the power-levels action named by `key`. Uses it in a new default override rule .org.matrix.msc4506.rule.knock (inserted before .m.rule.member_event, which otherwise suppresses all member events) so that members who can invite -- i.e. accept the knock (MSC2403) -- are pushed when someone knocks. Also lifts the member-event fast-path in the bulk evaluator for knocks, which otherwise evaluates rules for nobody (a knock's sender == state_key). Gated behind experimental_features.msc4506_enabled. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uk8aPxHn3BHCe52L226jdG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement MSC4506
Adds the
recipient_permissionpush rule condition; matches if and only if the user the rules are being evaluated for has a power level >= that required to perform the power-levels action named bykey.Uses it in a new default override rule
.org.matrix.msc4506.rule.knock(inserted before.m.rule.member_event, which otherwise suppresses all member events) so that members who can invite (i.e. accept the knock) are pushed when someone knocks.Gated behind
experimental_features.msc4506_enabled.Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.