Fix Runtime::snapshot access to GraphEntry node#83
Open
YuMuuu wants to merge 1 commit into
Open
Conversation
Author
|
This likely affects all releases from v4.0.0 through v4.0.8. a8923b8#diff-09113ad3ada3d29ef5720cd1d63e85b7a05ef4e3885f217f861f00d7d15f719e
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix
Runtime::snapshot()to accessgetProperties()through theGraphNodestored in eachGraphEntry.nodeTablemapsNodeIdtoGraphEntry, butGraphEntryitself does notprovide
getProperties(). The method belongs toGraphEntry::node.This regression appears to have been introduced in
a8923b8, when the mapped type of
nodeTablewas changed fromstd::shared_ptr<GraphNode<FloatType>>toGraphEntry.Reproduction
At commit 60e7234, run the following from the repository root:
Compilation fails with:
error: no member named 'getProperties' in 'elem::Runtime::GraphEntry'
The regular native build does not detect this because Runtime is a class
template and snapshot() is not instantiated unless it is used.
Change:
node->getProperties()
to:
entry.node->getProperties()
The reproduction command succeeds after this change.