Isolate Sniffers from Ksniff-wide Settings to avoid any side-affects#127
Open
MichaelWasher wants to merge 2 commits into
Open
Isolate Sniffers from Ksniff-wide Settings to avoid any side-affects#127MichaelWasher wants to merge 2 commits into
MichaelWasher wants to merge 2 commits into
Conversation
Copy kSniff Settings to internal PrivilegedPodSniffer state Create PrivilegedSnifferServiceConfig config struct to contain PrivilegedSnifferService configuration
…struct Create StaticTcpdumpSnifferServiceConfig config struct to contain StaticTcpdumpSnifferService configuration Copy kSniff settings on creation of StaticTcpdumpSnifferService to allow multi-use sniffer objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sniffers should maintain their own state without fear of changes 'bleeding' out to any global state.
If side-affects come from instantiating a sniffer, this limits the ability to use the sniffers as reusable components.
ksniff/pkg/service/sniffer/privileged_pod_sniffer_service.go
Lines 31 to 44 in e299ffb
This PR copies the relevant configuration into the Sniffer internal state. I think there is more that can be done for this (renaming) but I wanted to be as un-invasive as possible.