fix(push): coerce equivalent schedules to the same value (#1119)#1155
Open
shahzad31 wants to merge 1 commit into
Open
fix(push): coerce equivalent schedules to the same value (#1119)#1155shahzad31 wants to merge 1 commit into
shahzad31 wants to merge 1 commit into
Conversation
parseSchedule accumulated minutes and sub-minute seconds in separate buckets with inconsistent conversion, so equivalent durations such as `@every 1m59s` and `@every 119s` resolved to different schedules. Accumulate the whole duration as seconds and round to the nearest minute (breaking ties downward) before matching against the allowed schedules. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1119.
parseScheduleaccumulated the duration into separateminutesandsecondsbuckets with inconsistent conversion:svalue< 60was added tosecondsand then silently dropped bynearestSchedulewhenever minutes were presentsvalue>= 60was insteadMath.round-ed intominutesAs a result, two equal durations could coerce to different schedules:
This PR accumulates the whole duration as total seconds, then rounds to the nearest whole minute (breaking ties downward, so
2m30sstays at2mand never overshoots the requested cadence) before matching againstALLOWED_SCHEDULES. Equivalent durations now always resolve to the same schedule.Test plan
npx jest __tests__/push/monitor.test.ts -t "parse @every schedule format"passes@every 1m59sand@every 119sresolve to the same value, plus an explicit119s -> 2caseMade with Cursor