Added option for an SSL certificate chain to lumberjack server - #2
Closed
thefinn93 wants to merge 2 commits into
Closed
Added option for an SSL certificate chain to lumberjack server#2thefinn93 wants to merge 2 commits into
thefinn93 wants to merge 2 commits into
Conversation
Not sure if the client needs any changes, I tested it with logstash-forwarder and it worked well
|
@thefinn93 can you please sign the CLA? https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps |
Author
|
Done |
|
@thefinn93 thanks, this patch has been submitted with |
Conflicts: lib/lumberjack/server.rb
Author
|
There we go, should all be good. |
|
As I was preparing to send my pull request for the same issue, I this request was already here. I still decided to still submit my request as an alternative solution. Note that my solution does not require changes to any other code using the Server Class. |
Author
|
Ah nice, much cleaner than mine. +1 for #20 |
|
Thank you! |
|
Closing this in favor of #20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested it with logstash-forwarder and it worked well. I've submitted a pull request at logstash-plugins/logstash-input-lumberjack#30 to make use of these changes