Fix transform index spec#964
Merged
Merged
Conversation
2 tasks
jsoriano
commented
Aug 25, 2025
| } | ||
| if len(schema.Spec) == 0 { | ||
| return nil, fmt.Errorf("no spec found in schema file (path: %s)", l.source) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Safeguard added to avoid introducing this kind of issues again.
JohannesMahne
previously approved these changes
Aug 26, 2025
JohannesMahne
left a comment
JohannesMahne
left a comment
Contributor
There was a problem hiding this comment.
Thanks for picking this up and fixing it.
Contributor
Author
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#15050 |
Contributor
Author
|
Some settings are moved to definitions so they can be referenced and reused. |
Contributor
Author
|
test integrations |
💚 Build Succeeded
History
cc @jsoriano |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#15108 |
mrodm
approved these changes
Sep 2, 2025
| number_of_shards: | ||
| $ref: "../../data_stream/manifest.spec.yml#/definitions/index_template_setting_number_of_shards" | ||
| number_of_routing_shards: | ||
| description: Number used when splitting shards. |
Contributor
There was a problem hiding this comment.
Not sure that this description field is in the final JSON schema (after merging the $ref). But in any case, at least that description could help the developers as it is part of the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting to follow with #936 (comment), I found that no spec was being applied to the transform index manifests.
What does this PR do?
Fix transform index spec.
We removed
specfrom the manifests spec in #936 by mistake, add it back.A safeguard is added to avoid having spec files without
spec.Some settings are moved to its own definitions so they can be more easily referenced, without this change some settings could not be referenced, not sure why.
Also, drop
index.modefrom spec versions older than 3.4, aslookupmode is not supported in old versions of the stack.Why is it important?
Properly validate transform index definitions.
Checklist
I have added test packages toThere are tests covering this.test/packagesthat prove my change is effective.I have added an entry inFixes unreleased changes.spec/changelog.yml.Related issues