[Cisco ftd] Change type for filesize from integer to long#20083
[Cisco ftd] Change type for filesize from integer to long#20083robester0403 wants to merge 2 commits into
Conversation
robester0403
added
documentation
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
![vera-review-bot[bot]](https://avatars.githubusercontent.com/in/3297022?s=60&v=4){kind=small}
|
✅ All changelog entries have the correct PR link. |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
No issues across the latest commits cf4e5a5. Review summaryIssues found across earlier commits c5f9f64 — 1 medium, 1 low
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
| type: keyword | ||
| - name: file_size | ||
| type: integer | ||
| type: long |
There was a problem hiding this comment.
Have we considered using scaled_float ? apparently it's more efficient: https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/number#_which_type_should_i_use
I could not find proof that changing a type from integer to long is a breaking change, what I would consider is how this will impact querying legacy data though, if that is needed at all.
Example: If we query file size with float values as arguments, is it possible that we miss some entries that were originally stored as integers ?
There was a problem hiding this comment.
Seems like there's precedent and it was not considered a breaking change: #15673 (comment)
The TL;DR is that cross-family field change would be a breaking change, but not if we stay within the same family.
The integration docs also confirm that in a way by not explicitely listing same-family changes as breaking.
|
Tick the box to add this pull request to the merge queue (same as
|
2 participants
Proposed commit message
Convert FileSize to long instead of integer so large file sizes above the 32-bit integer limit no longer fail
Checklist
- [ ] I have verified that all data streams collect metrics or logs.changelog.ymlfile.- [ ] I have verified that Kibana version constraints are current according to guidelines.- [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practicesRelated issues
Resolves: https://github.com/elastic/sdh-beats/issues/7358
Screenshots