Skip to content

.github/workflows/go.yml - Add testing on FreeBSD#204

Merged
andrewkroh merged 2 commits into
elastic:mainfrom
andrewkroh:feature/freebsd-testing
Mar 14, 2024
Merged

.github/workflows/go.yml - Add testing on FreeBSD#204
andrewkroh merged 2 commits into
elastic:mainfrom
andrewkroh:feature/freebsd-testing

Conversation

@andrewkroh

@andrewkroh andrewkroh commented Mar 13, 2024

Copy link
Copy Markdown
Member

Add GH action step test execute unit tests on FreeBSD 14.0.
The tests run inside of a qemu VM running on top of a linux
worker.

Until a FreeBSD provider is present this step will test
nothing. It will become active as soon as files exist in
'providers/freebsd/'.

Relates: #126

@andrewkroh andrewkroh added the skip-changelog The change does not require a changelog entry. label Mar 13, 2024
Comment thread .github/workflows/go.yml Outdated
@andrewkroh andrewkroh force-pushed the feature/freebsd-testing branch 3 times, most recently from 541dabb to 69e1bb6 Compare March 14, 2024 13:59
andrewkroh and others added 2 commits March 14, 2024 10:05
Add GH action step test execute unit tests on FreeBSD 14.0.
The tests run inside of a qemu VM running on top of a linux
worker.

Until a FreeBSD provider is present this step will test
nothing. It will become active as soon as files exist in
'providers/freebsd/'.
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@andrewkroh andrewkroh force-pushed the feature/freebsd-testing branch from 69e1bb6 to 34ab8db Compare March 14, 2024 14:08
@andrewkroh andrewkroh marked this pull request as ready for review March 14, 2024 14:08
@andrewkroh andrewkroh requested a review from lhirlimann March 14, 2024 14:09
@andrewkroh

andrewkroh commented Mar 14, 2024

Copy link
Copy Markdown
Member Author

I will be opening a separate PR to update the Go versions in the other parts of the pipelines to test on 1.22.x.

@lhirlimann lhirlimann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh enabled auto-merge (squash) March 14, 2024 14:19
@andrewkroh andrewkroh mentioned this pull request Mar 14, 2024
@andrewkroh andrewkroh requested a review from v1v March 14, 2024 14:44
Comment thread .github/workflows/go.yml
Comment on lines +115 to +119
freebsd-version
pwd
ls -lah
whoami

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required, no. But I didn't see any downside to not having it. There's already a ton of logging happening with the freebsd plugin so this is like a drop in the bucket.

@andrewkroh andrewkroh merged commit 3c80dcf into elastic:main Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The change does not require a changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants